Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle UnobservedTaskExceptions without the Event Aggregator. … #539

Merged

Conversation

adamhathcock
Copy link
Member

… Logs will have them.

UnobservedTaskExceptions can easily flood the EA so don't process them with the EA.

Cancelling a send or receives (since SDK upgrades aren't merged) can reproduce the issue.

Related:
specklesystems/speckle-sharp-sdk#216
specklesystems/speckle-sharp-sdk#218
#527

Copy link

linear bot commented Jan 30, 2025

@adamhathcock adamhathcock merged commit f379996 into dev Jan 30, 2025
3 checks passed
@adamhathcock adamhathcock deleted the adam/cnx-1141-application-crash-and-stack-overflow-issue branch January 30, 2025 13:55
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 17.31%. Comparing base (48e66f9) to head (a98d80e).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...I3/Speckle.Connectors.DUI/ContainerRegistration.cs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #539      +/-   ##
==========================================
- Coverage   17.35%   17.31%   -0.05%     
==========================================
  Files         239      239              
  Lines        4805     4818      +13     
  Branches      579      579              
==========================================
  Hits          834      834              
- Misses       3941     3954      +13     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants