-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix Line Profile when there is NaN #2594
Conversation
jdaviz/configs/imviz/plugins/line_profile_xy/line_profile_xy.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 161 161
Lines 19602 19618 +16
=======================================
+ Hits 17942 17957 +15
- Misses 1660 1661 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Kyle Conroy <[email protected]>
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
Thanks for the reviews! @meeseeksdev backport to v3.8.x |
…4-on-v3.8.x Backport PR #2594 on branch v3.8.x (BUG: Fix Line Profile when there is NaN)
Description
This pull request is to address plotting line profiles when NaN is present. With this patch, the plot should now look like this instead of a blank plot:
I still see this in the browser dev console but does not seem to break Imviz:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.