Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix Line Profile when NaN exists #1951

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 28, 2022

Add test that fails on main without this patch.

Description

This pull request is to plot NaN as zero in Imviz Line Profile.

TODO

If there is a way to render NaN as gap in plot instead of as zero, it would be better. See Specviz behavior.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

Add test that fails on main without this patch.
@pllim pllim added the bug Something isn't working label Dec 28, 2022
@pllim pllim added this to the 3.2 milestone Dec 28, 2022
@github-actions github-actions bot added the imviz label Dec 28, 2022
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 91.79% // Head: 91.80% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c12f101) compared to base (04a744c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1951   +/-   ##
=======================================
  Coverage   91.79%   91.80%           
=======================================
  Files         140      140           
  Lines       14951    14965   +14     
=======================================
+ Hits        13724    13738   +14     
  Misses       1227     1227           
Impacted Files Coverage Δ
...s/imviz/plugins/line_profile_xy/line_profile_xy.py 99.07% <100.00%> (+0.02%) ⬆️
jdaviz/configs/imviz/tests/test_line_profile_xy.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor Author

pllim commented Dec 28, 2022

@kecnry thinks there is another way where we can render NaN as gap (like in Specviz) instead of forcing it as zero in plot, but I don't know how Specviz does that, so I am turning it back to draft for now.

@pllim pllim marked this pull request as draft December 28, 2022 17:44
@rosteen rosteen modified the milestones: 3.2, 3.3 Jan 4, 2023
@rosteen rosteen modified the milestones: 3.3, 3.4 Feb 9, 2023
@rosteen rosteen modified the milestones: 3.4, 3.5 Mar 22, 2023
@haticekaratay haticekaratay modified the milestones: 3.5, 3.6 May 25, 2023
@javerbukh javerbukh modified the milestones: 3.6, 3.7 Jul 28, 2023
@pllim pllim modified the milestones: 3.7, 3.8 Sep 21, 2023
@rosteen rosteen modified the milestones: 3.8, 3.9 Nov 29, 2023
@pllim
Copy link
Contributor Author

pllim commented Dec 6, 2023

The internals changed too much since, so this is superseded by #2594

@pllim pllim closed this Dec 6, 2023
@pllim pllim deleted the nan-desuka branch December 6, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants