Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rust 1.8 compatilbility issues #262

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix Rust 1.8 compatilbility issues #262

merged 2 commits into from
Sep 17, 2024

Conversation

supermarin
Copy link
Contributor

Fixes #259 .

@supermarin
Update deps
1bae79a 
Prep for Rust 1.8.
This takes care of some missing type annotations.
@supermarin
Update flake
06a9552
@supermarin
Copy link
Contributor Author

Not sure why CI didn't run. Tested on rust nightly and 1.7

@supermarin supermarin mentioned this pull request Sep 16, 2024
Closed
burmudar
burmudar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@burmudar burmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @supermarin!

@burmudar burmudar merged commit 76c97d9 into sourcegraph:master Sep 17, 2024
9 checks passed
@GaetanLepage GaetanLepage mentioned this pull request Sep 17, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burmudar burmudar burmudar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails with rust 1.80
2 participants
@supermarin @burmudar