Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.sg-nvim: 2024-09-09 -> 2024-09-17; fix #342486

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Sep 17, 2024

Description of changes

Fixed upstream in sourcegraph/sg.nvim#262.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 342486 run on x86_64-linux 1

2 packages built:
  • vimPlugins.sg-nvim
  • vimPluginsUpdater

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 342486 run on aarch64-darwin 1

2 packages built:
  • vimPlugins.sg-nvim
  • vimPluginsUpdater

@eljamm
Copy link
Contributor

eljamm commented Sep 17, 2024

Is it okay to have ; fix in the title and commit message? Would that not make ofborg not build the package?

@GaetanLepage
Copy link
Contributor Author

Is it okay to have ; fix in the title and commit message? Would that not make ofborg not build the package?

Looking at the GH ui, it doesn't seem to be a problem here.

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, then.

@GaetanLepage GaetanLepage merged commit 1fcc94e into NixOS:master Sep 17, 2024
33 of 35 checks passed
@GaetanLepage GaetanLepage deleted the sg-nvim branch September 17, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants