Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): migrate to use npm workspaces #1684

Merged
merged 9 commits into from
Nov 2, 2023
Merged

feat(chore): migrate to use npm workspaces #1684

merged 9 commits into from
Nov 2, 2023

Conversation

Surbhi-sharma1
Copy link
Contributor

@Surbhi-sharma1 Surbhi-sharma1 commented Sep 8, 2023

Migrate to use npm workspaces

BREAKING CHANGE:
lerna bootstrap command will not be needed as npm will manage the same functionality.

GH-1673

Description

Migrate to use npm workspaces

Fixes #1673

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as draft September 8, 2023 05:54
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Surbhi-sharma1 Surbhi-sharma1 force-pushed the GH-1673 branch 4 times, most recently from da05ff7 to 0e0618b Compare September 14, 2023 11:55
@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as ready for review September 18, 2023 06:01
shubhamp-sf and others added 6 commits October 19, 2023 14:12
MIGRATION CHANGE:
migration-20211003143854- no changes - just folder switch
migration-20210318100600- no changes - just folder switch
migration-20220607063927- no changes - just folder switch
migration-20220804102718-  no changes - just folder switch
migration-20220906105133-  no changes - just folder switch

GH-1673
prettier fix

MIGRATION CHANGE:
migration-20221122072057- fix lint issues in sandbox
migration-20221123082705- prettier fix
migration-20220620093215- prettier:fix

BREAKING CHANGE:
lerna bootstrap command will not be supported

GH-1673
fix sandbox lint issues

MIGRATION CHANGE:
migration-20221122072057- prettier fix

BREAKING CHANGE:
lerna bootstrap will not be supported

GH-1673
fix sonar code smell

MIGRATION CHANGE:
migration-20221123082900- fix prettier issu

BREAKING CHANGE:
lerna bootstrap command will not be supported

GH-1673
loopback and sourceloop version updates

MIGRATION CHANGE:
migration-20211003143854- added folder

BREAKING CHANGE:
lerna bootstrap will not be supported

GH-1673
@Surbhi-sharma1 Surbhi-sharma1 force-pushed the GH-1673 branch 6 times, most recently from 0f26ab2 to 01ce6d1 Compare October 20, 2023 08:46
fix merge conflicts

BREAKING CHANGE:
lerna bootstrap command will not be supported

GH-1673
remove support of node 16 in packages ,services and sandbox

GH-1673
@Surbhi-sharma1 Surbhi-sharma1 force-pushed the GH-1673 branch 2 times, most recently from 6e71363 to e4dd283 Compare October 31, 2023 04:35
package.json Show resolved Hide resolved
packages/cli/tsconfig.json Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating to Use npm Workspaces
5 participants