chore(all-services): remove node 16 support in packages ,sandbox and …

…services remove node 16 support in packages,sandbox and services GH-1673
sourcefuse · Oct 30, 2023 · 0237a40 · 0237a40
1 parent b2174c1
commit 0237a40
Show file tree

Hide file tree

Showing 48 changed files with 741 additions and 746 deletions.
diff --git a/packages/cache/package.json b/packages/cache/package.json
@@ -11,7 +11,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/packages/cli/src/generators/microservice/index.ts b/packages/cli/src/generators/microservice/index.ts
@@ -175,8 +175,7 @@ export default class MicroserviceGenerator extends AppGenerator<MicroserviceOpti
 
   writing() {
     if (!this.shouldExit()) {
-      // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-      if (this.options.baseService || this.options.datasourceName) {
+      if (this.options.baseService ?? this.options.datasourceName) {
         this._createDataSource();
       } else {
         this._createFacadeRedisDatasource();

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -23,7 +23,7 @@
     }
   },
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/packages/custom-sf-changelog/package.json b/packages/custom-sf-changelog/package.json
@@ -22,7 +22,7 @@
   ],
   "author": "Akshat Dubey",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "license": "ISC",
   "dependencies": {

diff --git a/packages/feature-toggle/package.json b/packages/feature-toggle/package.json
@@ -9,7 +9,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/audit-ms-example/package.json b/sandbox/audit-ms-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/sandbox/auth-ms-basic-example/package.json b/sandbox/auth-ms-basic-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/sandbox/auth-multitenant-example/package.json b/sandbox/auth-multitenant-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/sandbox/auth-multitenant-example/src/repositories/user-ext.repository.ts b/sandbox/auth-multitenant-example/src/repositories/user-ext.repository.ts
@@ -139,8 +139,7 @@ export class UserExtRepository extends DefaultSoftCrudRepository<
   async verifyPassword(username: string, password: string): Promise<User> {
     const user = await super.findOne({where: {username}});
     const creds = user && (await this.credentials(user.id).get());
-    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-    if (!user || user.deleted || !creds?.password) {
+    if (!user ?? user?.deleted ?? !creds?.password) {
       throw new HttpErrors.Unauthorized(AuthenticateErrorKeys.UserDoesNotExist);
     } else if (!(await bcrypt.compare(password, creds.password))) {
       throw new HttpErrors.Unauthorized(AuthErrorKeys.InvalidCredentials);
@@ -152,7 +151,7 @@ export class UserExtRepository extends DefaultSoftCrudRepository<
         AuthenticateErrorKeys.TempPasswordLoginDisallowed,
       );
     } else {
-      return user;
+      return user!;
     }
   }
 
@@ -163,8 +162,7 @@ export class UserExtRepository extends DefaultSoftCrudRepository<
   ): Promise<User> {
     const user = await super.findOne({where: {username}});
     const creds = user && (await this.credentials(user.id).get());
-    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-    if (!user || user.deleted || !creds?.password) {
+    if (!user ?? user?.deleted ?? !creds?.password) {
       throw new HttpErrors.Unauthorized(AuthenticateErrorKeys.UserDoesNotExist);
     } else if (!(await bcrypt.compare(password, creds.password))) {
       throw new HttpErrors.Unauthorized(AuthErrorKeys.WrongPassword);
@@ -175,9 +173,9 @@ export class UserExtRepository extends DefaultSoftCrudRepository<
     } else {
       // Do nothing
     }
-    await this.credentials(user.id).patch({
+    await this.credentials(user!.id).patch({
       password: await bcrypt.hash(newPassword, saltRounds),
     });
-    return user;
+    return user!;
   }
 }
diff --git a/sandbox/cache-example/package.json b/sandbox/cache-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/chat-notification-pubnub-example/facade/package.json b/sandbox/chat-notification-pubnub-example/facade/package.json
@@ -9,7 +9,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "private": true,
   "scripts": {

diff --git a/sandbox/chat-notification-pubnub-example/services/chat-service/package.json b/sandbox/chat-notification-pubnub-example/services/chat-service/package.json
@@ -10,7 +10,7 @@
   "types": "dist/index.d.ts",
   "private": true,
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/chat-notification-pubnub-example/services/notifications-service/package.json b/sandbox/chat-notification-pubnub-example/services/notifications-service/package.json
@@ -9,7 +9,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "private": true,
   "scripts": {

diff --git a/sandbox/chat-notification-socketio-example/facade/package.json b/sandbox/chat-notification-socketio-example/facade/package.json
@@ -9,7 +9,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "private": true,
   "scripts": {

diff --git a/sandbox/chat-notification-socketio-example/services/chat-service/package.json b/sandbox/chat-notification-socketio-example/services/chat-service/package.json
@@ -10,7 +10,7 @@
   "types": "dist/index.d.ts",
   "private": true,
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/chat-notification-socketio-example/services/notifications-service/package.json b/sandbox/chat-notification-socketio-example/services/notifications-service/package.json
@@ -9,7 +9,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "private": true,
   "scripts": {

diff --git a/sandbox/chat-notification-socketio-example/services/socketio-service/package.json b/sandbox/chat-notification-socketio-example/services/socketio-service/package.json
@@ -17,7 +17,7 @@
     "directory": "examples/socketio"
   },
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "private": true,
   "scripts": {

diff --git a/sandbox/feature-toggle-example/package.json b/sandbox/feature-toggle-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/sandbox/in-mail-example/package.json b/sandbox/in-mail-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/notification-socket-example/package.json b/sandbox/notification-socket-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/sandbox/oauth-example/package.json b/sandbox/oauth-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/oidc-basic-example/package.json b/sandbox/oidc-basic-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/payment-example/package.json b/sandbox/payment-example/package.json
@@ -9,7 +9,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "private": true,
   "scripts": {

diff --git a/sandbox/pubnub-example/package.json b/sandbox/pubnub-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/scheduler-example/package.json b/sandbox/scheduler-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "lb-tsc",

diff --git a/sandbox/search-ms-example/package.json b/sandbox/search-ms-example/package.json
@@ -9,7 +9,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "private": true,
   "scripts": {

diff --git a/sandbox/telemed-app/backend/authentication-service/package.json b/sandbox/telemed-app/backend/authentication-service/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": ">=10.16"
+    "node": "18 || 20"
   },
   "scripts": {
     "build:layers": "scripts/build-dependency-layer.sh",

diff --git a/sandbox/telemed-app/backend/notification-service/package.json b/sandbox/telemed-app/backend/notification-service/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": ">=10.16"
+    "node": "18 || 20"
   },
   "scripts": {
     "build:layers": "scripts/build-dependency-layer.sh",

diff --git a/sandbox/telemed-app/backend/video-conferencing-service/package.json b/sandbox/telemed-app/backend/video-conferencing-service/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": ">=10.16"
+    "node": "18 || 20"
   },
   "scripts": {
     "build:layers": "scripts/build-dependency-layer.sh",

diff --git a/sandbox/video-conferencing-ms-example/package.json b/sandbox/video-conferencing-ms-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/sandbox/workflow-ms-example/package.json b/sandbox/workflow-ms-example/package.json
@@ -10,7 +10,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "engines": {
-    "node": "16 || 17 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "build": "npm run clean && lb-tsc",

diff --git a/services/audit-service/package.json b/services/audit-service/package.json
@@ -9,7 +9,7 @@
     "main": "dist/index.js",
     "types": "dist/index.d.ts",
     "engines": {
-        "node": "16 || 17 || 18"
+        "node": "18 || 20"
     },
     "scripts": {
         "build": "npm run clean && lb-tsc && npm run openapi-spec && npm run apidocs",

diff --git a/services/audit-service/src/services/job-processing.service.ts b/services/audit-service/src/services/job-processing.service.ts
@@ -69,10 +69,8 @@ export class JobProcessingService {
           (customFilter.actedOn == null ||
             filterUsed.actedOn == null ||
             filterUsed.actedOn === customFilter.actedOn) &&
-          // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-          (customFilter.entityId ||
-            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-            filterUsed.entityId ||
+          (customFilter.entityId ??
+            filterUsed.entityId ??
             filterUsed.entityId === customFilter.entityId) &&
           (customFilter.date == null ||
             filterUsed.date == null ||

diff --git a/services/authentication-service/package.json b/services/authentication-service/package.json
@@ -9,7 +9,7 @@
     "main": "dist/index.js",
     "types": "dist/index.d.ts",
     "engines": {
-        "node": "16 || 17 || 18"
+        "node": "18 || 20"
     },
     "scripts": {
         "prebuild": "npm run clean",

diff --git a/services/bpmn-service/package.json b/services/bpmn-service/package.json
@@ -9,7 +9,7 @@
     "main": "dist/index.js",
     "types": "dist/index.d.ts",
     "engines": {
-        "node": "16 || 17 || 18"
+        "node": "18 || 20"
     },
     "scripts": {
         "build": "npm run clean && lb-tsc && npm run openapi-spec && npm run apidocs",

diff --git a/services/chat-service/package.json b/services/chat-service/package.json
@@ -9,7 +9,7 @@
     "main": "dist/index.js",
     "types": "dist/index.d.ts",
     "engines": {
-        "node": "16 || 17 || 18"
+        "node": "18 || 20"
     },
     "scripts": {
         "openapi-spec": "node ./dist/openapi-spec && npm run apidocs",