-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT use pixi to manage the CI dependencies #928
Conversation
.github/workflows/pixi-testing.yml
Outdated
@@ -0,0 +1,29 @@ | |||
name: Unit Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume in the future this would replace testing.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep it was to have a first push to not remove the previous file :)
while you're tinkering with the CI you may want to see #899 as well |
I think the CI is failing because the "Required" CI are failing because I removed the script. |
verbose: true | ||
if: success() | ||
name: 'Upload coverage to CodeCov' | ||
token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to setup the secret in GitHub if it does not exist.
Co-authored-by: Jérôme Dockès <[email protected]>
with: | ||
directory: ${{ runner.temp }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we are now running the tests from the source directory? I think that's not ideal with the current layout of the package because it could end up being imported from the pwd? or maybe I am missing something
env: | ||
INSTALL_NIGHTLY: "true" | ||
DEPS_VERSION: "dev" | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there's no way to specify this environment with pixi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, it does not make sense to use pixi
because you don't want to lock the nightly builds.
In this manner, we also test that our pip
command of pyproject.toml
work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @glemaitre ! this simplifies the CI configuration while fixing several issues
closes #708 , closes #899, closes #860
Let's see if we can use
pixi
to have kind of lock files system to not have failing CI when contributing.Here, I wanted to check that everything works before to go further.
It should be noted that the
pixi.toml
file can be merged withpyproject.toml
and I don't think that we need anymore thesetup.cfg
as well.