Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT use pixi to manage the CI dependencies #928

Merged
merged 42 commits into from
Jun 17, 2024

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jun 6, 2024

closes #708 , closes #899, closes #860

Let's see if we can use pixi to have kind of lock files system to not have failing CI when contributing.

Here, I wanted to check that everything works before to go further.

It should be noted that the pixi.toml file can be merged with pyproject.toml and I don't think that we need anymore the setup.cfg as well.

@glemaitre glemaitre marked this pull request as draft June 6, 2024 15:01
pixi.lock Outdated Show resolved Hide resolved
@@ -0,0 +1,29 @@
name: Unit Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume in the future this would replace testing.yml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it was to have a first push to not remove the previous file :)

@jeromedockes
Copy link
Member

while you're tinkering with the CI you may want to see #899 as well

@glemaitre
Copy link
Member Author

I think the CI is failing because the "Required" CI are failing because I removed the script.

verbose: true
if: success()
name: 'Upload coverage to CodeCov'
token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to setup the secret in GitHub if it does not exist.

@glemaitre glemaitre marked this pull request as ready for review June 17, 2024 11:44
with:
directory: ${{ runner.temp }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we are now running the tests from the source directory? I think that's not ideal with the current layout of the package because it could end up being imported from the pwd? or maybe I am missing something

env:
INSTALL_NIGHTLY: "true"
DEPS_VERSION: "dev"
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's no way to specify this environment with pixi?

Copy link
Member Author

@glemaitre glemaitre Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, it does not make sense to use pixi because you don't want to lock the nightly builds.

In this manner, we also test that our pip command of pyproject.toml work

Copy link
Member

@jeromedockes jeromedockes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @glemaitre ! this simplifies the CI configuration while fixing several issues

@jeromedockes jeromedockes merged commit c389e56 into skrub-data:main Jun 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect github action matrix description development status in setup.cfg
2 participants