MAINT add support for Python 3.9 #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the macos + python 3.8 fails to install pre-commit; not really related to skrub. As #928 will redo the CI configuration I won't edit it here |
|
the latest scikit-learn release only supports 3.9 so I wonder if we should set that as our minimum supported version? OTOH we support older scikit-learn versions that work with python 3.8 |
glemaitre
approved these changes
Jun 12, 2024
ah I see what happened -- we require all tests to pass in the CI before allowing to merge a PR. That includes the py3.10 tests, but they don't exist anymore because i replaced 3.10 with 3.9 (the matrix of os/python/dependencies combinations is already huge) I guess I'll just add 3.10 back; anyway this is temporary because your pixi PR will redo the configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #868, closes #815