Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): use upstream googleapis_auth package #1952

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore(shorebird_cli): use upstream googleapis_auth package #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions packages/shorebird_cli/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,19 +286,18 @@ packages:
dependency: transitive
description:
name: google_identity_services_web
sha256: "000b7a31e1fa17ee04b6c0553a2b2ea18f9f9352e4dcc0c9fcc785cf10f2484e"
sha256: "9482364c9f8b7bd36902572ebc3a7c2b5c8ee57a9c93e6eb5099c1a9ec5265d8"
url: "https://pub.dev"
source: hosted
version: "0.2.2"
version: "0.3.1+1"
googleapis_auth:
dependency: "direct main"
description:
path: googleapis_auth
ref: "647f96d5ffdae63e41aeea091c34acfffff533e7"
resolved-ref: "647f96d5ffdae63e41aeea091c34acfffff533e7"
url: "https://github.com/shorebirdtech/googleapis.dart.git"
source: git
version: "1.5.0"
name: googleapis_auth
sha256: befd71383a955535060acde8792e7efc11d2fccd03dd1d3ec434e85b68775938
url: "https://pub.dev"
source: hosted
version: "1.6.0"
graphs:
dependency: transitive
description:
Expand Down Expand Up @@ -359,10 +358,10 @@ packages:
dependency: transitive
description:
name: js
sha256: f2c445dce49627136094980615a031419f7f3eb393237e4ecd97ac15dea343f3
sha256: c1b2e9b5ea78c45e1a0788d29606ba27dc5f71f019f32ca5140f61ef071838cf
url: "https://pub.dev"
source: hosted
version: "0.6.7"
version: "0.7.1"
json_annotation:
dependency: "direct main"
description:
Expand Down Expand Up @@ -406,10 +405,10 @@ packages:
dependency: "direct main"
description:
name: mason_logger
sha256: "0e90e637dcfcb7fb6c30b38e71cd41fa0e4e3df6f1da177f8251ac3f15147e9f"
sha256: "56c44e588e908ef0d1dbb593e1b4473b8ee5fb48fcc8d645c925ab6c8041ebdf"
url: "https://pub.dev"
source: hosted
version: "0.2.12"
version: "0.2.15"
matcher:
dependency: transitive
description:
Expand Down Expand Up @@ -494,10 +493,10 @@ packages:
dependency: transitive
description:
name: pointycastle
sha256: "70fe966348fe08c34bf929582f1d8247d9d9408130723206472b4687227e4333"
sha256: "79fbafed02cfdbe85ef3fd06c7f4bc2cbcba0177e61b765264853d4253b21744"
url: "https://pub.dev"
source: hosted
version: "3.8.0"
version: "3.9.0"
pool:
dependency: transitive
description:
Expand Down
6 changes: 1 addition & 5 deletions packages/shorebird_cli/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,7 @@ dependencies:
cli_util: ^0.4.1
collection: ^1.18.0
crypto: ^3.0.3
googleapis_auth:
git:
url: https://github.com/shorebirdtech/googleapis.dart.git
path: googleapis_auth
ref: 647f96d5ffdae63e41aeea091c34acfffff533e7
googleapis_auth: ^1.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to bump the min dart sdk version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind just checked and it looks like googleapis_auth min is 3.0.0 so we're good 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may a dependency of that project that requires a higher version. Checking with an older Dart version now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like several of our dependencies require newer versions of Dart than our pubspec currently says it requires. http 1.2.1 requires Dart 3.3.0, for example.

http: ^1.2.1
intl: ^0.19.0
io: ^1.0.4
Expand Down
Loading