chore(shorebird_cli): use upstream googleapis_auth package #1952
Conversation
|
Does this bump our minimum Dart version? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 174 174
Lines 5493 5493
=========================================
Hits 5493 5493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| url: https://github.com/shorebirdtech/googleapis.dart.git | ||
| path: googleapis_auth | ||
| ref: 647f96d5ffdae63e41aeea091c34acfffff533e7 | ||
| googleapis_auth: ^1.6.0 |
There was a problem hiding this comment.
Don't we also need to bump the min dart sdk version?
There was a problem hiding this comment.
nevermind just checked and it looks like googleapis_auth min is 3.0.0 so we're good 👍
There was a problem hiding this comment.
I think there may a dependency of that project that requires a higher version. Checking with an older Dart version now.
There was a problem hiding this comment.
It looks like several of our dependencies require newer versions of Dart than our pubspec currently says it requires. http 1.2.1 requires Dart 3.3.0, for example.
bryanoltman
changed the title
|
We already pull our own Dart. I'm not sure what call we're making that's not using it: |
|
Yeah, we have our own Dart, we should just fix cases where we're using the wrong one. |
Description
Fixes #1944
Type of Change