Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshooting): fix copy for native and asset changes #264

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Jul 9, 2024

Status

READY

Description

  • docs(troubleshooting): fix copy for native and asset changes

@felangel felangel self-assigned this Jul 9, 2024
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do we link to this from the shorebird patch cli output?

@felangel
Copy link
Contributor Author

felangel commented Jul 9, 2024

lgtm. Do we link to this from the shorebird patch cli output?

We link to https://docs.shorebird.dev/troubleshooting#unexpected-native-changes which should still work.

Edit: nevermind that link was already broken even before this change. I'll open a separate PR to fix it.

@felangel felangel merged commit ca2fb80 into main Jul 9, 2024
3 checks passed
@felangel felangel deleted the docs/fix/troubleshooting branch July 9, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants