Skip to content

Commit

Permalink
docs(troubleshooting): fix copy for native and asset changes (#264)
Browse files Browse the repository at this point in the history
  • Loading branch information
felangel authored Jul 9, 2024
1 parent a6bab12 commit ca2fb80
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/content/docs/troubleshooting.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ version and build numbers in order to target patches at specific releases. You
can fix this problem by either setting `manageAppVersionAndBuildNumber` to false
or removing the value from your export options .plist file.

## I see a `The release artifact contains asset changes` warning when running `shorebird release` (#asset-changes)
## I see a `Your app contains asset changes` warning when running `shorebird patch` (#asset-changes)

The `shorebird patch` command will print a warning if it detects changes to
files in your compiled app that correspond to asset changes (e.g. added or
Expand Down Expand Up @@ -197,7 +197,7 @@ warning, you should be very careful about publishing your patch, as it may
cause your app to crash when the Dart code tries to call into native code
which operates differently than expected. See
{/* cspell:disable-next-line */}
[the next section](#i-see-a-the-release-artifact-contains-native-changes-warning-when-running-shorebird-patch-even-though-i-havent-changed-swiftobjective-ckotlinjava-code).
[the next section](#i-see-a-your-app-contains-native-changes-warning-when-running-shorebird-patch-even-though-i-havent-changed-swiftobjective-ckotlinjava-code).

### What happens if I ignore this warning?

Expand All @@ -211,7 +211,7 @@ If you are not sure whether your change is safe, you can
[stage your patch](/guides/staging-patches) and test locally before deploying it
to users.

## I see a `The release artifact contains native changes` warning when running `shorebird patch`, even though I haven't changed Swift/Objective-C/Kotlin/Java code
## I see a `Your app contains native changes` warning when running `shorebird patch`, even though I haven't changed Swift/Objective-C/Kotlin/Java code

The `shorebird patch` command will print a warning if it detects changes to
files in your compiled app that correspond to native code changes (`.dex` files
Expand Down

0 comments on commit ca2fb80

Please sign in to comment.