Frontend: Created the Homepage with the hamburger menu #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menu I Created the home page with hamburger menu based on the given figma design, i added the necessary media in assets/src and also slightly modified button component, also added some custom classes in tailwind.config.js. I showed just for instance the sidebar after login, which will be later implemented. Fixes: shivansh-bhatnagar18#78
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We should add an AppContext handling user signin and use it here to sync the UI with logged in state. |
|
@kuv2707 The PR looks good to me. Its just that the images are not getting rendered. |
|
Bhaiya it might be the loading error, because it is opening in my localhost |
kuv2707
reviewed
Jun 10, 2024
kuv2707
reviewed
Jun 10, 2024
kuv2707
reviewed
Jun 10, 2024
| }; | ||
|
|
||
| const Navbar: React.FC<NavbarProps> = ({ | ||
| isLoggedIn, |
There was a problem hiding this comment.
These will be accessed via the context, which I'll add when I get time.
There was a problem hiding this comment.
So what I do here
shivansh-bhatnagar18
merged commit d38c29c
into
shivansh-bhatnagar18:master
8 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I Created the home page with hamburger menu based on the given figma design. I added created the menu in Navbar.tsx and import this in home.tsx(landing page). I also added the necessary media in assets/src and also slightly modified my previously button component, also added some custom classes in tailwind.config.js. I showed just for instance the sidebar after login, which will be later implemented.
Fixes: #78
How to Test
Related Issues
Checklist
Screenshots