Frontend: Added Login Page with modifications to other components #88
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -22,6 +23,8 @@ const router = createBrowserRouter([ | |||
| }, | |||
| { path: '/about', element: <About /> }, | |||
| { path: '/error', element: <Error /> }, | |||
| { path: '/login', element: <Login />}, | |||
There was a problem hiding this comment.
We'd only want to keep one of these.
There was a problem hiding this comment.
So the new users with no account will be directed to the login page ?
There was a problem hiding this comment.
Oh i see
We'd use sign-up or register for that, not sign-in
signin and login mean the same thing
|
We won't be using google auth right now (that can be done later) A technical note: Both login and signup are quite identical, but differ in the api call and that signup ( = for first time users) will have a confirm password field. |
|
@PrathamX595 Login is implemented in the backend, so you can test if everything works as expected. |
I'll get it done latest by Tomorrow only a few changes are left |
|
@kuv2707 implemented the authContext let me know if anything else is needed to done |
added a Login page with changes to input and button components. routes for login and signin pages were also added Fixes: shivansh-bhatnagar18#79 integrated AuthContext added Signup page
shivansh-bhatnagar18
merged commit c195d3b
into
shivansh-bhatnagar18:master
Added Login Page & Signup Page with other modifications
Fixes: #79
Description
Added a login page with changes to some components namely:
1)Button component was changed to include
typeas a prop.2)Input button was changed to adjust the roundness and the height and width props were made editable .
3)NavBar was modified to conditionally render the signin/login button.
4)Routes for Login and Signup pages were added.
5)Implemented authContext to the login page
How to Test
npm run devRelated Issues
#80
#87
#76
Checklist
Screenshots (if applicable)