Client:Implemented the input component #80
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ritwik-69 Can you please use tailwind for styling of components as much as possible? Also I am configuring Kavoom to the tailwind file so change the fonts accordingly. |
|
@shivansh-bhatnagar18 I used tailwing css and configured it to include kavoon font |
|
@ritwik-69 Please update the screenshots, and rebase your branch once (against upstream/master) |
|
@kuv2707 done with the changes |
|
@ritwik-69 Please fix the merge conflicts. The component looks good but add some basic parameters as width and height as parameters. Also remove the related input CSS files because you are already using tailwind |
|
@shivansh-bhatnagar18 I don't understand why vercel deployment is failing? |
|
@ritwik-69 You are still importing ./input.css in the input.tsx. To check why this deployment fails try running npm run build |
sorry about that 🤦♂️ |
|
@shivansh-bhatnagar18 Done with the changes |
kuv2707
added
can be merged soon
under review
kuv2707
force-pushed
the
master
branch
3 times, most recently
from
4dd6ce4 to
7bc3d56
Compare
|
@ritwik-69 Please change the font to kavoon |
This commit creates the Input component as discussed and made in figma. As props it takes normal input properties like placeholder,value etc. The styling has been done in input.css (I had to rename it input.css from input.module.css as it was not working when importing) fixes:shivansh-bhatnagar18#77
shivansh-bhatnagar18
merged commit 6098f08
into
shivansh-bhatnagar18:master
fixes:#77
Description
Created the Input component as discussed and made in figma. As props it takes normal input properties like placeholder,value etc. The styling has been done in input.css (I had to rename it input.css from input.module.css as it was not working when importing)
Motivation and Context
[Explain the motivation behind these changes and provide any relevant context.]
How to Test
[Describe the steps to test the changes made in this pull request.]
Related Issues
[If applicable, mention any related issues or pull requests.]
Checklist
Screenshots (if applicable)
[If your changes include any visual updates, provide screenshots here.]