Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shreyansh added a shuffle algo to the deck #36

Closed
wants to merge 2 commits into from
+7 −2
Closed

shreyansh added a shuffle algo to the deck #36

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
848730b
shreyansh added a shuffle algo to the deck
Shreyansh200528 Jun 1, 2024
82ff7e2
removed comments
Shreyansh200528 Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion backend/uno-game-engine/deck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const colors: Array<CardColor> = ['red', 'yellow', 'green', 'blue'];

Check failure on line 1 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'colors' is assigned a value but never used
const values = [

Check failure on line 2 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'values' is assigned a value but never used
'0',
'1',
'2',
Expand All @@ -14,8 +14,8 @@
'reverse',
'draw2',
];
const specialCards = ['wild', 'draw4'];

Check failure on line 17 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'specialCards' is assigned a value but never used
const deck = [];

Check failure on line 18 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'deck' is assigned a value but never used
const sameCardCount = []; // to keep track of same cards in assigning unique id to each card

/**
Expand Down Expand Up @@ -74,7 +74,13 @@
* This function shuffles the elements of the given array *in place* . The function behaves in a type-agnostic way.
* Time complexity: O(n)
*/
export function shuffle(deck: Array<any>) {

Check failure on line 77 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

Unexpected any. Specify a different type
//todo: Implement a generic shuffling algorithm
[deck[0], deck[1]] = [deck[1], deck[0]];
//[deck[0], deck[1]] = [deck[1], deck[0]];
Shreyansh200528 marked this conversation as resolved.
Show resolved Hide resolved
for (var i = deck.length - 1; i > 0; i--) {

Check failure on line 80 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

Unexpected var, use let or const instead
var j = Math.floor(Math.random() * (i + 1));

Check failure on line 81 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

Unexpected var, use let or const instead
var temp = deck[i];

Check failure on line 82 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

Unexpected var, use let or const instead
deck[i] = deck[j];
deck[j] = temp;
}
}
Loading