Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shreyansh added a shuffle algo to the deck #36

Closed

Conversation

Shreyansh200528
Copy link

Description

i have created a shuffle algo to the deck

it gets the original deck and change index of each element.
(this is my first pull request so there is a high chance I did something wrong so please correct me on that)

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 2, 2024

@Shreyansh200528 You can change the commit message to match the prescribed format.

@kuv2707 kuv2707 added the approved Pull requests which could not be merged but are decent enough to be counted as a contribution. label Jun 2, 2024
@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 2, 2024

Nicely implemented the algo, but issues with commit history.
Since the issue is already closed, I am closing the PR.
I have added the approved label to it. (Which we'll use while counting contribution)

@kuv2707 kuv2707 closed this Jun 2, 2024
@kuv2707 kuv2707 added approved: Kislay and removed approved Pull requests which could not be merged but are decent enough to be counted as a contribution. labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants