frontend: Added error Page #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@PrathamX595 Please remove the merge commit and use rebase to sync your branch with upstream/master. Also please adhere to the commit message format as described in CONVENTIONS.md |
|
@kuv2707 I am having trouble removing the merge commit can someone assist me ? |
PrathamX595
force-pushed
the
master
branch
2 times, most recently
from
d0d1b15 to
8aa2dfe
Compare
|
@kuv2707 I have implemented the recommended changes let me know if anything else needs to be done. |
kuv2707
reviewed
Jun 2, 2024
backend/src/types.d.ts
Outdated
| @@ -27,6 +27,10 @@ type EventResult = { | |||
| message: string; | |||
| }; | |||
|
|
|||
| declare global { | |||
There was a problem hiding this comment.
Please remove all changes to this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Error Page
Fixes: #21
Description
added an error page which is rendered when an unknown route is accessed, it contains a link to go back to home page of the game.
How to Test
npm run devin the console and open the application./k(or any other route which is not recognized by the router) after the existing text.Checklist
Screenshots (if applicable)