frontend: added error page #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the default vite react app css as its not going to be used in the future and it was interferring with the existing components. fixes:shivansh-bhatnagar18#43
added an error page which is rendered when an unknown route is accessed Fixes: shivansh-bhatnagar18#21
kuv2707
force-pushed
the
master
branch
2 times, most recently
from
fe179ab to
199d751
Compare
|
Seems good to me, but the design decisions will be made by others |
|
Thank you @PrathamX595 for your Pull Request. Every Pull request matters but we have found out a better Error page for the same. For now I am closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Error Page
Fixes: #21
Description
added an error page which is rendered when an unknown route is accessed, it contains a link to go back to home page of the game.
How to Test
npm run devin the console and open the application./k(or any other route which is not recognized by the router) after the existing text.Checklist
Screenshots (if applicable)