Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Display The Player Whose Turn It Is Currently #165

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

asmit27rai
Copy link
Contributor

@asmit27rai asmit27rai commented Jun 25, 2024

Description

  1. Brightened player icons for active turn indication.

  2. Displayed current player's name on game board.

  3. Tailwind CSS utility classes have been applied for consistent styling of the player's name.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots

Screenshot 2024-06-27 000533

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 6:33pm

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 25, 2024

Just to be clear, we display every player's name below the cards, and in a separate place, display the name of the player currently having turn, right?

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 25, 2024

Both of these things are being tracked in separate issues, and this one deals with displaying the current player's name in some central location.

@asmit27rai
Copy link
Contributor Author

Just to be clear, we display every player's name below the cards, and in a separate place, display the name of the player currently having turn, right?

Yes ,here it will showing the player's name currently having turn.

@asmit27rai
Copy link
Contributor Author

Both of these things are being tracked in separate issues, and this one deals with displaying the current player's name in some central location.

So should i show the name of player currently having turn at center of board or where?

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 26, 2024

We should display the current player's name in some central location.
All the individual players will also have their names displayed

@asmit27rai
Copy link
Contributor Author

We should display the current player's name in some central location. All the individual players will also have their names displayed

OK I will update the PR accordingly.

1. Brightened player icons for active turn indication.

2. Displayed current player's name on game board.

Fixes: shivansh-bhatnagar18#157
@asmit27rai
Copy link
Contributor Author

asmit27rai commented Jun 26, 2024

@kuv2707 Done With All The Changes.

@kuv2707 kuv2707 merged commit d59fdf1 into shivansh-bhatnagar18:master Jun 28, 2024
7 of 8 checks passed
@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 28, 2024

This works for now, thanks @asmit27rai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants