Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display player names along with cards #158

Closed
kuv2707 opened this issue Jun 24, 2024 · 6 comments · Fixed by #171
Closed

Display player names along with cards #158

kuv2707 opened this issue Jun 24, 2024 · 6 comments · Fixed by #171

Comments

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 24, 2024

Description

  • We can add the player name in a suitable place around their card count.
    image

  • We should refactor out the JSX responsible for rendering the player cards etc into its own Player component.

  • We should be able to use it like:

<Player player={gameState.players[i]} highlighted={true} />

The highlighted prop highlights the player if it is their turn.
@issue-assigner issue-assigner
Copy link

Comment '@csoc-bot claim' to get this issue assigned or '@csoc-bot abandon' to get this issue unassigned.

@draunger
Copy link
Contributor

draunger commented Jun 25, 2024 •
edited
Loading

@csoc-bot claim

@issue-assigner issue-assigner
Copy link

@draunger This issue has been successfully assigned to you! 🚀

@kuv2707
Copy link
Collaborator Author

kuv2707 commented Jun 25, 2024

@draunger You can take up #130 since this one is being worked on inadvertently in #165

@kuv2707
Copy link
Collaborator Author

kuv2707 commented Jun 27, 2024

@asmit27rai This is related to your work

@asmit27rai
Copy link
Contributor

@asmit27rai This is related to your work
OK

asmit27rai added a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 27, 2024
@asmit27rai
Frontend: Display Player names along with cards
df7fb72 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
@asmit27rai asmit27rai mentioned this issue Jun 27, 2024
Merged
4 tasks
asmit27rai added a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 27, 2024
@asmit27rai
Frontend: Display Player names along with cards
f6af5de 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
4243c7a 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
5a46a5b 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
b96d78d 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
39d04d8 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
df7a07b 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
e22f88e 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
d36fa48 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
c207aca 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
d9930ce 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
asmit27rai pushed a commit to asmit27rai/multiplayer-uno that referenced this issue Jun 28, 2024
@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
ad1c831 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Frontend: Display Player names along with cards asmit27rai/multiplayer-uno
3 participants
@kuv2707 @draunger @asmit27rai