Use golangci-lint

.github/workflows/ci.yml

@@ -4,6 +4,10 @@ on:
     push:
       branches: [ main ]
 name: ci/github
+
+permissions:
+  contents: read
+
 jobs:
     unit:
         strategy:
@@ -33,7 +37,7 @@ jobs:
           uses: actions/setup-go@v2
           with:
             go-version: ${{ matrix.go-version }}
-        - name: Check out code
+        - name: Checkout code
           uses: actions/checkout@v2
         - name: Verify fmt
           run: make verify-fmt
@@ -43,6 +47,10 @@ jobs:
           run: make verify-manifests
         - name: Verify OLM bundle
           run: make verify-bundle
+        - name: Run golangci-lint
+          uses: golangci/golangci-lint-action@v2
+          with:
+            args: --timeout=10m
     e2e:
         strategy:
           fail-fast: false

.golangci.yml

@@ -0,0 +1,3 @@
+linters:
+  enable:
+    - gosec

controllers/shipwrightbuild_controller.go

@@ -7,12 +7,13 @@ package controllers
 import (
 	"context"
 	"fmt"
+	"path/filepath"
+
 	"github.com/go-logr/logr"
 	mfc "github.com/manifestival/controller-runtime-client"
 	"github.com/manifestival/manifestival"
 	tektonoperatorv1alpha1 "github.com/tektoncd/operator/pkg/apis/operator/v1alpha1"
 	tektonoperatorv1alpha1client "github.com/tektoncd/operator/pkg/client/clientset/versioned/typed/operator/v1alpha1"
-	"path/filepath"
 
 	corev1 "k8s.io/api/core/v1"
 	crdclientv1 "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1"
@@ -112,7 +113,7 @@ func (r *ShipwrightBuildReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 			return RequeueWithError(err)
 		}
 		if version.Minor() < 49 {
-			retErr := fmt.Errorf("Shipwright requires at least v0.49.0 of the Tekton Operator, but the minor number is %d", version.Minor())
+			retErr := fmt.Errorf("shipwright requires at least v0.49.0 of the Tekton Operator, but the minor number is %d", version.Minor())
 			return RequeueWithError(retErr)
 		}
 
@@ -245,7 +246,7 @@ func (r *ShipwrightBuildReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 			Reason:  "Failed",
 			Message: fmt.Sprintf("Reconciling ShipwrightBuild failed: %v", err),
 		})
-		r.Client.Status().Update(ctx, b)
+		err = r.Client.Status().Update(ctx, b)
 		return RequeueWithError(err)
 	}
 	if err := r.setFinalizer(ctx, b); err != nil {
@@ -261,7 +262,7 @@ func (r *ShipwrightBuildReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 	})
 	if err := r.Client.Status().Update(ctx, b); err != nil {
 		logger.Error(err, "updating ShipwrightBuild status")
-		RequeueWithError(err)
+		RequeueWithError(err) //nolint:errcheck
 	}
 	logger.Info("All done!")
 	return NoRequeue()

controllers/shipwrightbuild_controller_test.go

@@ -51,10 +51,10 @@ func bootstrapShipwrightBuildReconciler(
 
 	logger := zap.New()
 
-	c := fake.NewFakeClientWithScheme(s, b)
-	crdClient := &crdclientv1.Clientset{}
-	toClient := &tektonoperatorv1alpha1client.Clientset{}
-	if tcrds != nil && len(tcrds) > 0 {
+	c := fake.NewFakeClientWithScheme(s, b) //nolint:golint,staticcheck
+	var crdClient *crdclientv1.Clientset
+	var toClient *tektonoperatorv1alpha1client.Clientset
+	if len(tcrds) > 0 {
 		objs := []runtime.Object{}
 		for _, obj := range tcrds {
 			objs = append(objs, obj)

controllers/suite_test.go

@@ -6,18 +6,18 @@ package controllers
 
 import (
 	"context"
-	tektonoperatorv1alpha1client "github.com/tektoncd/operator/pkg/client/clientset/versioned/typed/operator/v1alpha1"
-	crdclientv1 "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1"
 	"path/filepath"
 	"testing"
 	"time"
 
+	tektonoperatorv1alpha1client "github.com/tektoncd/operator/pkg/client/clientset/versioned/typed/operator/v1alpha1"
+	crdclientv1 "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1"
+
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 
 	apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 	"k8s.io/client-go/kubernetes/scheme"
-	"k8s.io/client-go/rest"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/envtest"
@@ -32,7 +32,6 @@ import (
 // These tests use Ginkgo (BDD-style Go testing framework). Refer to
 // http://onsi.github.io/ginkgo/ to learn more about Ginkgo.
 
-var cfg *rest.Config
 var k8sClient client.Client
 var ctx context.Context
 var testEnv *envtest.Environment
@@ -74,7 +73,7 @@ var _ = BeforeSuite(func() {
 	Expect(err).NotTo(HaveOccurred())
 	crdClient, err := crdclientv1.NewForConfig(mgr.GetConfig())
 	Expect(err).NotTo(HaveOccurred())
-	toClient, err := tektonoperatorv1alpha1client.NewForConfig(mgr.GetConfig())
+	toClient, _ := tektonoperatorv1alpha1client.NewForConfig(mgr.GetConfig())
 	err = (&ShipwrightBuildReconciler{
 		CRDClient:            crdClient,
 		TektonOperatorClient: toClient,