Use golangci-lint

[vancanhuit]

Changes

Closes #35

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

[vancanhuit]

/assign @adambkaplan

[SaschaSchwarze0]

Correcting the repository name and adding the timeout like in the CLI.

[SaschaSchwarze0]

@vancanhuit golintci-lint ran. A few findings to be fixed.

[vancanhuit]

Do we need to temporarily disable some rules to make it pass?

[SaschaSchwarze0]

Do we need to temporarily disable some rules to make it pass?

I'd say no. None of the findings sounds complicated to be addressed. Let us know if you find one where you need help.

[vancanhuit]

Is there an environmental issue in the e2e run?

[adambkaplan]

@vancanhuit I also noticed that you used a merge commit to bring in changes from main. If possible, can you try rebasing instead?

[vancanhuit]

@vancanhuit I also noticed that you used a merge commit to bring in changes from main. If possible, can you try rebasing instead?

Yes, I will try.

[adambkaplan]

@vancanhuit this PR is failing tests for the same reason I outlined in #41 (comment). Unfortunately you are stuck until #52 merges (and you will need to rebase afterwards 😿).

[adambkaplan]

@vancanhuit #52 has now merged. Please rebase this pull request on top of the current main branch, then I think the e2e tests will be fixed.

[vancanhuit]

@adambkaplan I rebased this PR. Please check if it is ok. The same with #41.

[adambkaplan]

/approve

Looks good to merge. Ideally we have a make target that lets contributors run this locally - we can follow up in a separate pull request.

[adambkaplan]

Verify failed:

Verify check failed - run `make generate` and commit the resulting changes to git.
+ echo 'Verify check failed - run `make generate` and commit the resulting changes to git.'
+ exit 1
make: *** [Makefile:124: verify-generate] Error 1

[vancanhuit]

CI now is green @adambkaplan 👍

[adambkaplan]

/approve

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment