Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-scylla-node: Remove run_once from io_properties block and fix CI #336

Merged
merged 2 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ provisioner:
# skip_ntp: True
skip_swap: True
scylla_manager_deb_repo_url: "http://downloads.scylladb.com/deb/ubuntu/scylladb-manager-2.6-bionic.list"
scylla_yaml_params:
force_schema_commit_log: true
consistent_cluster_management: true
playbooks:
converge: ../shared/converge.yml
prepare: ../shared/prepare.yml
Expand Down
1 change: 0 additions & 1 deletion ansible-scylla-node/tasks/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
- set_fact:
io_conf: "{{ _io_conf.stdout_lines[0] }}"
when: io_properties is not defined and scylla_io_probe|bool == True and (scylla_io_probe_dc_aware|bool == False or dc_to_node_list[dc][0] == inventory_hostname)
run_once: "{{ not scylla_io_probe_dc_aware|bool }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this run_once doing here indeed?...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this expression is strange too from Ansible syntax perspective.

become: true

- name: For every node, check if io.conf already exists and if it's not empty
Expand Down
Loading