ansible-scylla-node: Remove run_once from io_properties block and fix CI #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorribeiroduarte
force-pushed
the
remove_run_once
branch
from
a986485 to
5b66644
Compare
Assuming `scylla_io_probe == true`, this `run_once` had the following logic:
* If `scylla_io_probe_dc_aware` was false, the block would run only once and
copy the io_properties from the first node to all the others
* If it was true the block would run for all the hosts and every node
would measure its own io_properties
However, having `scylla_io_probe_dc_aware` set to false means that we don't know
if the nodes configuration will be the same, meaning that we'd rather measure
io_properties per node than copy it from the first node.
This PR fixes this problem by removing the `run_once`.
Now, we'll only copy io_properties to other nodes in the following scenarios:
* if both, `scylla_io_probe` and `scylla_io_probe_dc_aware` are set to `true`,
then we copy the io_properties from the first node of each DC to all the
others of the same DC.
* if io_properties is explicitly set via ansible params, its value will be
copied to the nodes of all DCs.
igorribeiroduarte
force-pushed
the
remove_run_once
branch
from
5b66644 to
52ac789
Compare
In the latest enterprise version, if we use the defaults from Scylla we'll see the following error: `init - Bad configuration: consistent_cluster_management requires schema commit log to be enabled` This happens because consistent_cluster_management is set to true and force_schema_commit_log is set to false by default. This PR fixes this error in our CI by setting force_schema_commit_log to true in scylla_yaml_params.
igorribeiroduarte
changed the title
| @@ -82,7 +82,6 @@ | |||
| - set_fact: | |||
| io_conf: "{{ _io_conf.stdout_lines[0] }}" | |||
| when: io_properties is not defined and scylla_io_probe|bool == True and (scylla_io_probe_dc_aware|bool == False or dc_to_node_list[dc][0] == inventory_hostname) | |||
| run_once: "{{ not scylla_io_probe_dc_aware|bool }}" | |||
There was a problem hiding this comment.
What was this run_once doing here indeed?...
There was a problem hiding this comment.
And this expression is strange too from Ansible syntax perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming
scylla_io_probe == true, thisrun_oncehad the following logic:scylla_io_probe_dc_awarewas false, the block would run only once and copy the io_properties from the first node to all the othersHowever, having
scylla_io_probe_dc_awareset to false means that we don't know if the nodes configuration will be the same, meaning that we'd rather measure io_properties per node than copy it from the first node.This PR fixes this problem by removing the
run_once.Now, we'll only copy io_properties to other nodes in the following scenarios:
scylla_io_probeandscylla_io_probe_dc_awareare set totrue, then we copy the io_properties from the first node of each DC to all the others of the same DC.