-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you for the chore! Yeah, I think fixing the issue needs some more investigation (I think the issue might just be about emitting the 128bit float pixel because I guess that's a rare use case. I wonder the new jxl-oxide supports lower precision number types?
Some nits:
Welcome, I fixed the nits!
Good to know, I don't have a lot of experience on image processing but I might try to have a look. |
I pushed a last commit that remove some unwrap by using pattern matching. The logic is the same but if you prefer the old code I can revert it. |
I do like them but diffing is now harder, can we do that in a separate PR? |
Perfect, I removed the last commit and clean the commit history. Thanks for the quick response and to still manage this repo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few more nits:
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Done! |
Thank you so much! So helpful 👍🙏 |
Hello, thank you for this amazing work. It works on my machine with only a small issue. (the color profile for thumbnails)
I quickly updated the dependencies to see if this would fix it but sadly it did not.
Here is a PR with the updates, you are free to do whatever you want with it.
If you have any request of modification feel free to ask. I have some spare time.