Remove some unwraps #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
reviewed
Mar 1, 2024
| .expect("There should be a color context here") | ||
| .InitializeFromMemory(&decoded.icc[..])?; | ||
| if let Some(context) = ppicolorcontexts.as_mut() { | ||
| if ccount == 1 { |
There was a problem hiding this comment.
Maybe this can even do tuple match? 👀
There was a problem hiding this comment.
I tried matching and if let a tuple but I found them less readable than just nesting if. Sadly chaining if let is not stable yet.
Suggested change
| if ccount == 1 { | |
| if let (Some(context), 1) = (ppicolorcontexts.as_mut(), ccount) { |
Use pattern matching to avoid .is_none() and .unwrap()
|
Wow you fixed the color issues!!! Amazing thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the whole codebase to try to understand how to solve the color issue I found some unneeded unwraps.
This don't change any logic since the unwraps they are checked before using them.
This is more a style preference. (I like clean Rust 😄)
One advantage is when searching for unwraps and except, now only the unchecked one are listed.
Follow up on #35, need it to be merge before reviewing.