Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera calibration tests #42

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Camera calibration tests #42

merged 6 commits into from
Mar 21, 2024

Conversation

braden6521
Copy link
Collaborator

@braden6521 braden6521 commented Mar 21, 2024 •
edited
Loading

  • Added sort statement to fix errors with CameraCalibration unit tests.
  • Only failed test is test_with_attrfile
  • Added missing test_ prefix to reprojection error test so that it runs.

@braden6521 braden6521 requested a review from e10harvey March 21, 2024 16:17
e10harvey
e10harvey approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@e10harvey e10harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @braden6521 !

@e10harvey e10harvey merged commit bceb9cc into sandialabs:develop Mar 21, 2024
0 of 3 checks passed
This was referenced Mar 21, 2024
Merged
Closed
@braden6521 braden6521 deleted the camera_cal_tests branch April 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e10harvey e10harvey e10harvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braden6521 @e10harvey