-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15 make the tests work #40
Conversation
…nary file changes are from renames and the contents haven't actually changed (note: still does string matching verification against these files and their names)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bbean23! In general everything looks great! Braden and I will be working on the ubi8 test failures tomorrow. Other than the pypylon version change, I think this can be merged as long as no new test failures are introduced from the dependency version changes in requirements.txt.
ubi8 camera calibration errors fixed via: #42. |
… add warning when pypylon version is below the recommended version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me, Ben!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are also some features added to sensitive strings in this PR.
Going forward, I would prefer that features be separated into a different PR from the test fixes.
Yeah, I really should have split that out into another ticket, sorry. Thanks for the review! |
closes #15