Test fixes #38
Closed
Test fixes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braden6521
reviewed
Mar 20, 2024
| @@ -104,8 +134,8 @@ def tile_figure( | |||
| ul_y = size_y_pixels * y_idx | |||
|
|
|||
| # Create figure. | |||
| # fig = plt.figure(constrained_layout=True).subplots(5, 5) | |||
| fig = plt.figure(name, figsize=(size_x, plot_size_y)) | |||
| # fig = figure(constrained_layout=True).subplots(5, 5) | |||
There was a problem hiding this comment.
If you think it's a good idea, could we remove this commend out line? For the sake of preserving what we know works and minimizing the likelihood of someone accidently bringing up this error again.
There was a problem hiding this comment.
That's OK with me. @bbean23 what do you think?
There was a problem hiding this comment.
I think it'd be good to remove the commented out line. Note that the figure() method name changed again in #15, so you should probably pull again.
|
Closing in favor of #40. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.