-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add integration tests for user domain #2322
Open
iamacook
wants to merge
11
commits into
main
Choose a base branch
from
user-wallet-integration-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8392bdb
fix: add integration tests for user domain
iamacook 2bc51fe
fix: add integration tests for wallet
iamacook 03d013e
fix: add tests for triggers
iamacook c196283
fix: make `user_id` of `Wallet` non-nullable
iamacook 5ce39a0
fix: wallet tests
iamacook 0448687
fix: update tests
iamacook d8fb541
fix: rename ORM repositories and remove comment
iamacook 28b329a
fix: compare time
iamacook e9de543
fix: throw if not `Date`
iamacook 668d5d2
fix: get repositories after migration
iamacook 5b119ed
fix: get DB repositories in tests
iamacook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import type { MigrationInterface, QueryRunner } from 'typeorm'; | ||
|
||
export class WalletUserIdNullable1738684563598 implements MigrationInterface { | ||
name = 'WalletUserIdNullable1738684563598'; | ||
|
||
public async up(queryRunner: QueryRunner): Promise<void> { | ||
await queryRunner.query( | ||
`ALTER TABLE "wallets" DROP CONSTRAINT "FK_wallets_user_id"`, | ||
); | ||
await queryRunner.query( | ||
`ALTER TABLE "wallets" ALTER COLUMN "user_id" SET NOT NULL`, | ||
); | ||
await queryRunner.query( | ||
`ALTER TABLE "wallets" ADD CONSTRAINT "FK_wallets_user_id" FOREIGN KEY ("user_id") REFERENCES "users"("id") ON DELETE CASCADE ON UPDATE NO ACTION`, | ||
); | ||
} | ||
|
||
public async down(queryRunner: QueryRunner): Promise<void> { | ||
await queryRunner.query( | ||
`ALTER TABLE "wallets" DROP CONSTRAINT "FK_wallets_user_id"`, | ||
); | ||
await queryRunner.query( | ||
`ALTER TABLE "wallets" ALTER COLUMN "user_id" DROP NOT NULL`, | ||
); | ||
await queryRunner.query( | ||
`ALTER TABLE "wallets" ADD CONSTRAINT "FK_wallets_user_id" FOREIGN KEY ("user_id") REFERENCES "users"("id") ON DELETE CASCADE ON UPDATE NO ACTION`, | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This otherwise defaults to
true
meaning thatWallet
s could be added without aUser
.