fix: add integration tests for user domain #2322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Feb 4, 2025
| @@ -19,6 +19,7 @@ export class Wallet implements z.infer<typeof WalletSchema> { | |||
|
|
|||
| @ManyToOne(() => User, (user: User) => user.id, { | |||
| onDelete: 'CASCADE', | |||
| nullable: false, | |||
There was a problem hiding this comment.
This otherwise defaults to true meaning that Wallets could be added without a User.
PooyaRaki
reviewed
Feb 5, 2025
PooyaRaki
reviewed
Feb 6, 2025
PooyaRaki
reviewed
Feb 6, 2025
PooyaRaki
reviewed
Feb 6, 2025
PooyaRaki
reviewed
Feb 6, 2025
|
@PooyaRaki, I'm having issues with the tests passing. I initially thought it was because I moved the |
PooyaRaki
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We test the user (and wallet) domain via controller tests. This adds integration tests for the repositories of the aforementioned controller, covering database-relevant cases.
Changes
Wallet['user_id']non-nullableUserRepositoryWalletRepository