Cargo opts #924
Open
Cargo opts #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lockfile seems very old and in a different syntax. I need to
update parking_lot and cargo wants to update everything.
In my environment, the tests do the same thing before and after:
everything passes, except for
test::it_can_find_a_webdriver_on_path
test::it_can_run_browser_tests
which seem to be suffering some kind of problem with either my
installation or with an upstream service they use.
Signed-off-by: Ian Jackson <[email protected]>
I want to use parking_lot::const_rwlock, which is not available in 0.6.x. Most of our dependencies seem to be on parking_lot 0.10, so let's use that, even though parking_lot 0.11 exists. Signed-off-by: Ian Jackson <[email protected]>
3 tasks
These may affect any subcommand that is interested. Currently there aren't any. I experimented with passing a struct reference as a parameter throughout the code, but that was extremely intrusive. Signed-off-by: Ian Jackson <[email protected]>
Replace all open-coded instances of Command::new("cargo") with a call
to global_opts(). This will allow the global options to influence how
we run cargo.
No functional change at this stage.
I did a git grep for '"cargo"' to find all the occurrences. One
open-coded instance remains, in tests/all/utils/fixture.rs. This is
not part of wasm-pack; rather, it is test machinery, so it should not
try to use wasm-pack's global_opts().
Signed-off-by: Ian Jackson <[email protected]>
This allows passing some other program instead of cargo, such as a cargo wrapper program. Signed-off-by: Ian Jackson <[email protected]>
|
FTAOD these conflicts are due to #883. I am no longer using wasm-pack, but if it is being maintained and this MR is welcome, I could fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Here is a series let to the user influence the way wasm-pack runs cargo. Closes #923. Please see that issue for rationale and other options I considered.
I hope this meets with your approval. Please let me know what you think.
Template checklist
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨