Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parking_lot from direct dependency #883

Conversation

tetsuharuohzeki
Copy link

We don't use this crate now. This fix #882

Make sure these boxes are checked! πŸ“¦βœ…

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ πŸ˜„ Thanks so much for contributing to wasm-pack! πŸ˜„ ✨✨

We don't use this crate now.
@EverlastingBugstopper EverlastingBugstopper self-requested a review July 27, 2020 16:16
@ijackson
Copy link

Hi. FYI, my MR #924 reintroduces direct use of parking_lot, so this MR ought now to wait until we see what becomes of mine. Sorry to be making your cleanup obsolete...

@tetsuharuohzeki tetsuharuohzeki deleted the rm-unused-parking-lot-from-dependency branch April 12, 2022 12:53
@ijackson ijackson mentioned this pull request Apr 13, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parking_lot is not used as direct dependency
3 participants