Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marvin Attack on rsa crate #1825

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add Marvin Attack on rsa crate #1825

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a8ac8
[WIP] Add Marvin Attack on `rsa` crate
tarcieri Nov 28, 2023
50f4b68
Update crates/rsa/RUSTSEC-0000-0000.md
tarcieri Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions crates/rsa/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "rsa"
date = "2023-11-22"
keywords = ["cryptography"]
categories = ["crypto-failure"]
url = "https://github.com/RustCrypto/RSA/issues/19#issuecomment-1822995643"
tarcieri marked this conversation as resolved.
Show resolved Hide resolved

[versions]
patched = []
```

# Marvin Attack: potential key recovery through timing sidechannels

The [Marvin Attack] is a timing sidechannel vulnerability which allows
performing RSA decryption and signing operations as an attacker with the
ability to observe only the time of the decryption operation performed with
the private key.

A recent survey of RSA implementations found that the Rust `rsa` crate is one
of many implementations vulnerable to this attack.

No fixed version is available at this time.
Copy link
Member Author

@tarcieri tarcieri Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on adding the prerequisites to crypto-bigint needed to fix this problem, but it's going to be a lot of work (it presently uses a fork of num-bigint which wasn't designed for constant-time cryptography)


[Marvin Attack]: https://people.redhat.com/~hkario/marvin/