-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Marvin Attack on rsa
crate
#1825
Conversation
A recent survey of RSA implementations found that the Rust `rsa` crate is one | ||
of many implementations vulnerable to this attack. | ||
|
||
No fixed version is available at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on adding the prerequisites to crypto-bigint
needed to fix this problem, but it's going to be a lot of work (it presently uses a fork of num-bigint
which wasn't designed for constant-time cryptography)
71eea6d
to
a1a8ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go as-is, but if you think a patched version is going to go out in a week or two I'm fine with holding it back until that is available.
rsa
cratersa
crate
I'm a bit worried about publishing an advisory which has no call-to-action / mitigation. But given the potential severity, it's probably better to inform users and channel discussion to places where we can give authoritative answers, rather than having people discover it elsewhere and speculate. A week or two might be an ambitious target for fixing this, although I have implemented most of the necessary functionality to do so in the |
See: RustCrypto/RSA#19 (comment)
https://people.redhat.com/~hkario/marvin/