avm1: Implement __resolve #16284
Merged
avm1: Implement __resolve #16284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-avm1
core/src/avm1/object.rs
Outdated
| if let Some(resolve) = find_resolve_method(orig_proto, activation)? { | ||
| let result = | ||
| resolve.call("__resolve".into(), activation, this.into(), &[name.into()])?; | ||
| return Ok(Some((result, 0))); |
There was a problem hiding this comment.
Is 0 the correct depth result for all __resolve calls?
There was a problem hiding this comment.
I'm not sure it's possible to know, and it likely doesn't matter. It only applies to super as far as I can tell, and that can't apply with something returned through __resolve.
However, __resolve tries to act like the thing existed on the property itself; so 0 is probably as correct as anything!
adrian17
approved these changes
May 15, 2024
sleepycatcoding
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16182
When combined with #16282, this fixes http://www.eugenicsarchive.org/eugenics/list2.pl (but not g2conline, sadly)