Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content of text file does not display correctly due to unimplemented TextField.StyleSheet.transform #16290

Open
danielhjacobs opened this issue May 11, 2024 · 4 comments
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working text Issues relating to text rendering/input

Comments

@danielhjacobs
Copy link
Contributor

danielhjacobs commented May 11, 2024

Describe the bug

Edited May 20th, 2024: If you click x to skip the video or wait for the video to finish which takes a while, the objects beneath the whiteboard can be clicked and load text. However, the text doesn't appear with the correct styling. See screenshot:

Screenshot from 2024-05-20 09-58-19

Expected behavior

The text content is meant to be appropriately styled. See screenshot:

Screenshot from 2024-05-20 09-59-17

Content Location

https://labcenter.dnalc.org/labs/restrictionanalysis/restrictionanalysis_d.html

Affected platform

Self-hosted version

Operating system

Android 14

Browser

Google Chrome 124

Additional information

No response

@danielhjacobs danielhjacobs added bug Something isn't working text Issues relating to text rendering/input A-avm1 Area: AVM1 (ActionScript 1 & 2) labels May 11, 2024
@danielhjacobs danielhjacobs changed the title Content of text file does not load due to unimplemented TextField.Stylesheet Content of text file does not load due to unimplemented TextField.StyleSheet May 11, 2024
@Dinnerbone
Copy link
Contributor

Dinnerbone commented May 15, 2024

With the combination of #16326, #16284 and #16282, this seems to work (though actual styling isn't implemented yet):

image

@danielhjacobs danielhjacobs changed the title Content of text file does not load due to unimplemented TextField.StyleSheet Content of text file does not display correctly due to unimplemented TextField.StyleSheet.transform May 20, 2024
@danielhjacobs
Copy link
Contributor Author

Changed the issue description and title to reflect the new issue instead. Honestly, it's not a big deal, as the content is now fully functional, but I thought I'd document it.

@kjarosh
Copy link
Member

kjarosh commented Jan 31, 2025

This does not only require StyleSheet.transform, but full fledged TextField.styleSheet (it works after implementing both)

@kjarosh
Copy link
Member

kjarosh commented Feb 2, 2025

After implementing TextField.styleSheet, a wrong font is being used. We should fall back to a bold font but we don't (probably based on the name: Myriad Pro Bold).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working text Issues relating to text rendering/input
Projects
None yet
Development

No branches or pull requests

3 participants