-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/processor output individual records for gratia, add CPU usage and memory metrics #54
Merged
rptaylor
merged 25 commits into
rptaylor:master
from
mwestphall:feature/processor-output-individual-records-for-gratia
Jun 21, 2024
Merged
Feature/processor output individual records for gratia, add CPU usage and memory metrics #54
rptaylor
merged 25 commits into
rptaylor:master
from
mwestphall:feature/processor-output-individual-records-for-gratia
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rptaylor
reviewed
May 24, 2024
rptaylor
reviewed
May 25, 2024
rptaylor
reviewed
May 25, 2024
rptaylor
reviewed
Jun 10, 2024
mwestphall
force-pushed
the
feature/processor-output-individual-records-for-gratia
branch
from
June 13, 2024 16:47
a0e56e7
to
fc4da2a
Compare
rptaylor
reviewed
Jun 14, 2024
rptaylor
reviewed
Jun 14, 2024
rptaylor
reviewed
Jun 14, 2024
rptaylor
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rptaylor
changed the title
Feature/processor output individual records for gratia
Feature/processor output individual records for gratia, add CPU usage and memory metrics
Jun 21, 2024
This was referenced Jun 21, 2024
Actually for the record I believe the cgroup-related differences we saw are due to using EL8 where the default is still cgroup v1, not because of the k8s version per se. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container_cpu_usage_seconds_total
.kube_pod_container_resource_requests{resource="memory"}
metric, similar to cores.@rptaylor The commit history is a bit messy for this change since I separated it out from the helm chart changes in-post, let me know if you'd like it condensed down with a rebase.