Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize queries to work if there is more than just 1 container in a pod #56

Open
rptaylor opened this issue Jun 12, 2024 · 1 comment
Open

Generalize queries to work if there is more than just 1 container in a pod #56

rptaylor opened this issue Jun 12, 2024 · 1 comment

Comments

@rptaylor
Copy link
Owner

Some queries currently only work for the case of a pod with one container.

At least for some queries, such as self.cores https://github.com/rptaylor/kapel/blob/master/python/KAPEL.py#L58 , this is easy to add by just putting sum by (pod) in front.

Reference discussion: #54 (comment)
@rptaylor rptaylor mentioned this issue Jun 12, 2024
Merged
@rptaylor rptaylor mentioned this issue Jun 21, 2024
Closed
@rptaylor
Copy link
Owner Author

rptaylor commented Jan 2, 2025

This could also be addressed by #71 , using kube_pod_resource_request instead of container-level resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rptaylor