Add codeAction support #298
Conversation
TwitchBronBron
changed the title
Added plugin events for codeActions.
|
|
||
| private addMissingExtends() { | ||
| //add the attribute at the end of the first attribute, or after the `<component` if no attributes | ||
| const pos = (this.file.parser.ast.component.attributes[0] ?? this.file.parser.ast.component.tag).range.end; |
There was a problem hiding this comment.
I'm not sure the position is correct for a tag without any attribute. You probably should just always insert at the end of the tag instead of trying to find the first attribute.
Also maybe have some const { component } = this.file.parser.ast; for readability.
There was a problem hiding this comment.
I did it this way so we don't occasionally insert two consecutive whitespaces. It's easier to reason about the whitespace after an attribute. Although I do agree that we should add this to the very end of the tag, so I adjusted this to find the FINAL attribute first, and then after the <component object second if there are no attributes
There was a problem hiding this comment.
Adding an attribute or a tag should be done with a helper function BTW, so it's testable and reusable.
There was a problem hiding this comment.
Good point. I'll do that.
Add type checking support for diagnostics
|
@elsassph I really want to get this feature merged, but I do agree that we should not leak internal xml ast data. So, I have ripped out that specific codeAction. So please give this PR a final review, and approve if you have no further concerns. I'll continue working on those other comments in separate PRs. |
| @@ -543,6 +550,22 @@ export class LanguageServer { | |||
| return item; | |||
| } | |||
|
|
|||
| private async onCodeAction(params: CodeActionParams) { | |||
| //ensure programs are initialized | |||
| await this.waitAllProgramFirstRuns(); | |||
There was a problem hiding this comment.
These awaits will potentially accumulate code action requests - should there instead be a mechanism to ignore codeactions when the file isn't ready? We may "miss" some actions but just moving the cursor around will produce then again.
There was a problem hiding this comment.
The language server protocol might already account for this and prevent additional requests if the first one hasn't resolved yet. So I'll test that first, and if we DO get multiple requests at the same time, then I'll add some code to ignore code actions that arrive before the programs are finished with their first runs.
There was a problem hiding this comment.
I just tested, and I can't get these to queue up. There's a waitAllProgramFirstRuns() in the onInitialized, so the vscode doesn't even send codeAction events until that's resolved, so this line is really a "just in case" measure.
This adds the ability to send code actions from the language server to the editor.
I created a helper (
util.createCodeAction) to simplify creating code actions (because they're kind of annoying to create.TODO