-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New docs template #7377
New docs template #7377
Conversation
2f12dab
to
76b61e6
Compare
The old colors are not AAA compliant. Comment in CSS notwithstanding |
I can try playing with the saturation some more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try playing with the saturation some more
Yes, I do think that is worth it.
All the rest looks good :)
I think the light mode syntax highlighting is good to go already |
Changes implemented as requested
@gamebox This has broken the highlighting of the current ( In #7382 I used If we want to use this background color for all entries, then perhaps the border style can be used to distinguish the current entry (have a look at the screenshots in #7382)? |
Just a prototypeThis is now being merged in earnest.
Desktop (Light/Dark mode side-by-side):
Desktop w/ Search (Light/Dark side-by-side):
Mobile(Dark mode):
Mobile w/ Sidebar open (Dark mode):
Mobile w/ Search open (Dark mode):
Mobile (light mode):
Mobile w/ Sidebar open (Light mode):
Mobile w/ Search open (Light mode):