Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs template #7377

Merged
merged 5 commits into from
Dec 19, 2024
Merged

New docs template #7377

merged 5 commits into from
Dec 19, 2024

Conversation

gamebox
Copy link
Collaborator

@gamebox gamebox commented Dec 15, 2024

Just a prototype

This is now being merged in earnest.

Desktop (Light/Dark mode side-by-side):
Screenshot 2024-12-18 at 8 47 45 AM

Desktop w/ Search (Light/Dark side-by-side):
Screenshot 2024-12-18 at 8 52 20 AM

Mobile(Dark mode):
Screenshot 2024-12-18 at 8 48 10 AM

Mobile w/ Sidebar open (Dark mode):
Screenshot 2024-12-18 at 8 48 53 AM

Mobile w/ Search open (Dark mode):
Screenshot 2024-12-18 at 8 49 26 AM

Mobile (light mode):
Screenshot 2024-12-18 at 8 50 04 AM

Mobile w/ Sidebar open (Light mode):
Screenshot 2024-12-18 at 8 51 26 AM

Mobile w/ Search open (Light mode):
Screenshot 2024-12-18 at 8 51 44 AM

@gamebox gamebox marked this pull request as ready for review December 18, 2024 14:52
@gamebox gamebox requested review from rtfeldman and Anton-4 December 18, 2024 14:52
@Anton-4
Copy link
Collaborator

Anton-4 commented Dec 18, 2024

The difference in colors for syntax highlighting has reduced significantly, could we re-use the old colors here?
Screenshot from 2024-12-18 16-26-44
left is current version | right is new

@gamebox
Copy link
Collaborator Author

gamebox commented Dec 18, 2024

The old colors are not AAA compliant. Comment in CSS notwithstanding

@gamebox
Copy link
Collaborator Author

gamebox commented Dec 18, 2024

I can try playing with the saturation some more

Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try playing with the saturation some more

Yes, I do think that is worth it.

All the rest looks good :)

@gamebox
Copy link
Collaborator Author

gamebox commented Dec 18, 2024

My newest changes will move the Dark Mode syntax highlighting to this color palette.

Screenshot 2024-12-18 at 4 34 48 PM

@gamebox
Copy link
Collaborator Author

gamebox commented Dec 18, 2024

I think the light mode syntax highlighting is good to go already

@lukewilliamboswell lukewilliamboswell dismissed Anton-4’s stale review December 19, 2024 00:39

Changes implemented as requested

@gamebox gamebox merged commit c9a1ca8 into roc-lang:main Dec 19, 2024
19 checks passed
@kukimik
Copy link
Contributor

kukimik commented Dec 30, 2024

@gamebox This has broken the highlighting of the current (:target) entry-name, see #7299 and #7382.

In #7382 I used background-color: var(--violet-bg); to highlight the entry pointed at by the #fragment part of the URI. But now all entries have this background color:

https://github.com/roc-lang/roc/blame/eda4db05894dd027b023803f8c9ffbc559b6900a/crates/docs/src/static/styles.css#L74

If we want to use this background color for all entries, then perhaps the border style can be used to distinguish the current entry (have a look at the screenshots in #7382)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants