Mark :target entry using border #7477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit a3762f6 marked the current (:target) entry using background color. But then 11e736f set the background color for all entries. Thus we need another way to highlight the entry pointed at by the URL fragment. Signed-off-by: Michał Kukieła <[email protected]>
|
I don't have strong opinions on this - what do you think @gamebox? |
|
I think I would just have a flash of that border after scrolled into view It’s nice but a little garish to keep around IMO As another option, I’ve seen other docs raise the background’s brightness for a few hundred millis. Could you try animating the border back to the normal state after some time? |
|
I'm happy to help if you need it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a3762f6 marked the current (:target) entry using background color. But then 11e736f set the background color for all entries. Thus we need another way to highlight the entry pointed at by the URL fragment.
See #7377 (comment).
Closes #7299 (see #7299 (comment)).
Screenshots: