Enable compilation of libYARP_math in the Python wheels
#2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
LGTM, but I think it would be better to have it in the yarp-3.5 branch, so that YARP 3.5.1 release will have this. @diegoferigo What do you think?
diegoferigo
force-pushed
the
fix/yarp_math_in_pypi
branch
from
800c78c to
74a7d56
Compare
Good idea, rebased on top of the 3.5 branch |
diegoferigo
requested review from
Nicogene,
randaz81 and
traversaro
as code owners
diegoferigo
force-pushed
the
fix/yarp_math_in_pypi
branch
from
74a7d56 to
34607dd
Compare
Nicogene
approved these changes
Sep 9, 2021
|
Merged, thanks @diegoferigo. |
drdanz
added
Component: Packaging
PR Type: Feat/Enh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eigen was missing in the debian container used to build the PEP600 wheels, and
libYARP_mathautomatically disabled by CMake. This PR adds the target to the process, hopefully fixing ami-iit/bipedal-locomotion-framework#296 (comment).