Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor low-level crypto to C++ style. #2292

Merged
merged 24 commits into from
Dec 10, 2024

Change ranner from macos-12 to macos-13 due to macos-12 deprecation

858ad09
Select commit
Loading
Failed to load commit list.
Merged

Refactor low-level crypto to C++ style. #2292

Change ranner from macos-12 to macos-13 due to macos-12 deprecation
858ad09
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

84.88% (+0.06%) compared to ddcbaa9

View this Pull Request on Codecov

84.88% (+0.06%) compared to ddcbaa9

Details

Codecov Report

Attention: Patch coverage is 85.69528% with 215 lines in your changes missing coverage. Please review.

Project coverage is 84.88%. Comparing base (ddcbaa9) to head (858ad09).

Files with missing lines Patch % Lines
src/lib/crypto/sm2.cpp 77.67% 25 Missing ⚠️
src/lib/crypto/elgamal.cpp 77.50% 18 Missing ⚠️
src/lib/crypto/rsa_ossl.cpp 88.75% 18 Missing ⚠️
src/lib/crypto/dsa.cpp 81.39% 16 Missing ⚠️
src/lib/crypto/dsa_ossl.cpp 84.15% 16 Missing ⚠️
src/lib/crypto/ecdh.cpp 84.94% 14 Missing ⚠️
src/lib/crypto/ossl_utils.hpp 82.05% 14 Missing ⚠️
src/lib/crypto/rsa.cpp 86.86% 13 Missing ⚠️
src/lib/crypto/ec.cpp 75.55% 11 Missing ⚠️
src/lib/crypto/ecdsa_ossl.cpp 73.80% 11 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
+ Coverage   84.81%   84.88%   +0.06%     
==========================================
  Files         116      114       -2     
  Lines       23346    22783     -563     
==========================================
- Hits        19802    19339     -463     
+ Misses       3544     3444     -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.