Refactor low-level crypto to C++ style.

.github/workflows/macos.yml

@@ -70,11 +70,11 @@ jobs:
       fail-fast: false
       matrix:
 # On MacOS gcc is alias of clang these days
-        os: [ macos-12, macos-13, macos-14 ]
+        os: [ macos-13, macos-14 ]
         backend: [ 'botan' ]
         shared_libs: [ 'on' ]
         include:
-          - { os: 'macos-12', backend: '[email protected]', shared_libs: 'on' }
+          - { os: 'macos-13', backend: '[email protected]', shared_libs: 'on' }
           - { os: 'macos-14', backend: 'openssl@3', shared_libs: 'on' }
           - { os: 'macos-14', backend: 'botan', shared_libs: 'off' }
           - { os: 'macos-14', backend: 'botan3', shared_libs: 'on' }

src/lib/CMakeLists.txt

@@ -241,7 +241,6 @@ configure_file(config.h.in config.h)
 
 if(CRYPTO_BACKEND_OPENSSL)
   set(CRYPTO_SOURCES
-    crypto/bn_ossl.cpp
     crypto/dsa_common.cpp
     crypto/dsa_ossl.cpp
     crypto/ec_curves.cpp
@@ -272,7 +271,6 @@ if(CRYPTO_BACKEND_OPENSSL)
   endif()
 elseif(CRYPTO_BACKEND_BOTAN)
   set(CRYPTO_SOURCES
-    crypto/bn.cpp
     crypto/dsa_common.cpp
     crypto/dsa.cpp
     crypto/ec_curves.cpp

src/lib/crypto/backend_version.cpp

@@ -31,12 +31,12 @@
 #elif defined(CRYPTO_BACKEND_OPENSSL)
 #include <openssl/opensslv.h>
 #include <openssl/crypto.h>
-#include "ossl_common.h"
 #if defined(CRYPTO_BACKEND_OPENSSL3)
 #include <openssl/provider.h>
 #endif
 #include <string.h>
 #include "config.h"
+#include "ossl_utils.hpp"
 #ifndef RNP_USE_STD_REGEX
 #include <regex.h>
 #else
@@ -142,15 +142,15 @@
     /* Load default crypto provider */
     state->def = OSSL_PROVIDER_load(NULL, "default");
     if (!state->def) {
-        RNP_LOG("Failed to load default crypto provider: %s", ossl_latest_err());
+        RNP_LOG("Failed to load default crypto provider: %s", rnp::ossl::latest_err());
         free(state);
         return false;
     }
     /* Load legacy crypto provider if needed */
 #if defined(OPENSSL_LOAD_LEGACY)
     state->legacy = OSSL_PROVIDER_load(NULL, "legacy");
     if (!state->legacy) {
-        RNP_LOG("Failed to load legacy crypto provider: %s", ossl_latest_err());
+        RNP_LOG("Failed to load legacy crypto provider: %s", rnp::ossl::latest_err());
         OSSL_PROVIDER_unload(state->def);
         free(state);
         return false;