Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete Kafka consumer group when source backfill is finished #20077

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 9, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Now Kafka consumer groups created by RisingWave Kafka source during backfill will be deleted when the backfill process is finished.

Copy link
Member Author

xxchan commented Jan 9, 2025

@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch 4 times, most recently from 75db837 to b273cf4 Compare January 9, 2025 09:32
@xxchan xxchan requested a review from a team as a code owner January 9, 2025 10:44
@xxchan xxchan requested review from xiangjinwu and removed request for a team January 9, 2025 10:44
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from b273cf4 to 4d87885 Compare January 9, 2025 10:44
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from 4d87885 to 99283e7 Compare January 15, 2025 02:13
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from 99283e7 to e4d51a9 Compare January 15, 2025 02:42
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch 2 times, most recently from 076a30f to 3f704a5 Compare January 15, 2025 06:21
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from d42e649 to 9a9021d Compare January 17, 2025 00:25
Base automatically changed from xxchan/drop-cg to main January 17, 2025 01:14
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from 9a9021d to 0904098 Compare January 17, 2025 01:14
Copy link

graphite-app bot commented Jan 17, 2025

Merge activity

  • Jan 17, 9:15 AM GMT+8: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from 0904098 to b8c4d1c Compare January 17, 2025 02:06
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from b8c4d1c to 226e404 Compare January 17, 2025 08:35
@xxchan xxchan force-pushed the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch from 226e404 to 5173648 Compare January 17, 2025 08:57
@xxchan xxchan added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 0695831 Jan 17, 2025
31 of 32 checks passed
@xxchan xxchan deleted the 01-09-feat_delete_kafka_consumer_group_when_source_backfill_is_finished branch January 17, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants