Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): splits source_manager into smaller mods #20071

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 8, 2025

Signed-off-by: xxchan [email protected]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Member Author

xxchan commented Jan 8, 2025

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve as no logic change

@xxchan xxchan force-pushed the xxchan/split_source branch from 7cbe311 to 1dc89f3 Compare January 8, 2025 10:00
@xxchan xxchan force-pushed the xxchan/split_source branch from 1dc89f3 to 00d90c8 Compare January 8, 2025 13:04
@xxchan xxchan added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit bb4dec2 Jan 8, 2025
31 of 32 checks passed
@xxchan xxchan deleted the xxchan/split_source branch January 8, 2025 13:51
lmatz pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants