Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpc calls to unregister recordings from catalog #8566

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add rpc calls to unregister recordings from catalog #8566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions crates/store/re_protos/proto/rerun/v0/remote_store.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ service StorageNode {
// metadata API calls
rpc QueryCatalog(QueryCatalogRequest) returns (stream DataframePart) {}
rpc UpdateCatalog(UpdateCatalogRequest) returns (UpdateCatalogResponse) {}

// TODO(zehiko) support registering more than one recording at a time
rpc RegisterRecording(RegisterRecordingRequest) returns (DataframePart) {}

rpc UnregisterRecording(UnregisterRecordingRequest) returns (UnregisterRecordingResponse) {}
rpc UnregisterAllRecordings(UnregisterAllRecordingsRequest) returns (UnregisterAllRecordingsResponse) {}
}

// ---------------- Common response message ------------------
Expand Down Expand Up @@ -41,6 +45,18 @@ message RegisterRecordingRequest {
DataframePart metadata = 4;
}

// ---------------- Unregister from catalog ------------------

message UnregisterRecordingRequest {
// unique identifier of the recording
rerun.common.v0.RecordingId recording_id = 1;
}
message UnregisterRecordingResponse {}

message UnregisterAllRecordingsRequest {}
message UnregisterAllRecordingsResponse {}


// ---------------- UpdateCatalog -----------------

message UpdateCatalogRequest {
Expand Down
187 changes: 187 additions & 0 deletions crates/store/re_protos/src/v0/rerun.remote_store.v0.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading